From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: phy: qcom: apq8064-sata: extract UNI PLL register defines Date: Sat, 16 May 2026 11:32:10 +1000 Message-ID: In-Reply-To: <20260513-fd-hdmi-phy-v9-3-ca98c72f1f9f@oss.qualcomm.com> References: <20260513-fd-hdmi-phy-v9-0-ca98c72f1f9f@oss.qualcomm.com> <20260513-fd-hdmi-phy-v9-3-ca98c72f1f9f@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Clean mechanical extraction of register defines from `phy-qcom-apq8064-sata.c` into a new shared header `phy-qcom-uniphy.h`. No functional change. **Case normalization**: The original defines used uppercase hex (`0x03C`, `0x04C`), while the new header uses lowercase (`0x03c`, `0x04c`). This is fine and consistent with the more common kernel style. **R-b tag**: Has `Reviewed-by: Neil Armstrong`. No issues. --- Generated by Claude Code Patch Reviewer