From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: aux-hpd: let drivers pass IRQ_HPD events Date: Sat, 16 May 2026 11:25:50 +1000 Message-ID: In-Reply-To: <20260513-hpd-irq-events-v3-3-086857017f16@oss.qualcomm.com> References: <20260513-hpd-irq-events-v3-0-086857017f16@oss.qualcomm.com> <20260513-hpd-irq-events-v3-3-086857017f16@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Renames `drm_bridge_hpd_notify` =E2=86=92 `drm_bridge_hpd_notify_extra` (ex= ported symbol) and `drm_aux_hpd_bridge_notify` =E2=86=92 `drm_aux_hpd_bridg= e_notify_extra`, while keeping the old names as inline wrappers that pass `= DRM_CONNECTOR_NO_EXTRA_STATUS`. The commit message says: "The drm_aux_hpd_bridge_notify() is keps to ease m= erging" =E2=80=94 typo: "keps" =E2=86=92 "kept". The approach of keeping compatibility wrappers as `static inline` in header= s is clean and avoids cross-tree merge headaches. Good. **Observation:** `drm_aux_hpd_bridge_notify()` inline wrapper is placed *af= ter* the `#endif` of the `CONFIG_DRM_AUX_HPD_BRIDGE` block: ```c #endif =20 +static inline void drm_aux_hpd_bridge_notify(struct device *dev, enum drm_= connector_status status) +{ + drm_aux_hpd_bridge_notify_extra(dev, status, DRM_CONNECTOR_NO_EXTRA_STATU= S); +} + #endif ``` This means it's always defined regardless of `CONFIG_DRM_AUX_HPD_BRIDGE`. W= hen the config is disabled, it will call the stub `drm_aux_hpd_bridge_notif= y_extra()` which is an empty inline =E2=80=94 so this is correct. But it's = slightly unusual placement. Consider moving it inside the `#ifdef` block an= d adding a corresponding stub in the `#else`. --- Generated by Claude Code Patch Reviewer