From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: tc358762: Improve LCDCTRL defines Date: Sat, 16 May 2026 12:04:21 +1000 Message-ID: In-Reply-To: <20260513-tc358762-fixes-v3-3-6698b55008b9@ideasonboard.com> References: <20260513-tc358762-fixes-v3-0-6698b55008b9@ideasonboard.com> <20260513-tc358762-fixes-v3-3-6698b55008b9@ideasonboard.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review This is the most important cleanup patch. The old LCDCTRL defines were sign= ificantly wrong: - Old `LCDCTRL_VTGEN BIT(4)` =E2=86=92 New `LCDCTRL_VTGEN BIT(1)` (the old = "VTGEN" was actually part of the pixel format field) - Old `LCDCTRL_UNK6 BIT(6)` =E2=86=92 part of `LCDCTRL_PXLFORM GENMASK(6,4)= `=20 - Old `LCDCTRL_RGB888 BIT(8)` =E2=86=92 New `LCDCTRL_DPI_EN BIT(8)` - Old `LCDCTRL_VSDELAY(v) (v<<20)` =E2=86=92 New `LCDCTRL_DCLK_POL BIT(20)` The commit message clearly explains the mapping. I verified: old value `LCD= CTRL_VSDELAY(1)|LCDCTRL_RGB888|LCDCTRL_UNK6|LCDCTRL_VTGEN` =3D `BIT(20)|BIT= (8)|BIT(6)|BIT(4)` =3D 0x100150, new value `FIELD_PREP(GENMASK(6,4),5)|LCDC= TRL_DPI_EN|LCDCTRL_DCLK_POL` =3D `0x50|0x100|0x100000` =3D 0x100150. Matche= s perfectly. Also correctly removes the "based on guesswork" comment, suggesting Tomi ha= s verified these against actual documentation. The polarity defines are ren= amed from `HSPOL`/`DEPOL`/`VSPOL` to `HSYNC_POL`/`DE_POL`/`VSYNC_POL` for c= larity. No issues. **Reviewed-by worthy.** --- Generated by Claude Code Patch Reviewer