From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: ite-it66121: Select HDMI or DVI mode based on sink type Date: Sat, 16 May 2026 09:32:45 +1000 Message-ID: In-Reply-To: <20260515090220.809830-4-javierm@redhat.com> References: <20260515090220.809830-1-javierm@redhat.com> <20260515090220.809830-4-javierm@redhat.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Good:** - The fix is minimal and correct. Checking `connector->display_info.is_hdmi= ` is the right way to determine the sink type. - The `IT66121_HDMI_MODE_DVI` define (value 0) is a nice readability improv= ement even though it's just clearing the bit. **Observation:** This is the actual bug-fix patch. When DVI mode is selecte= d, patch 1's infoframe helpers will still be called from `drm_atomic_helper= _connector_hdmi_update_infoframes`, but the HDMI connector framework should= handle this correctly by not sending infoframes when `is_hdmi` is false (s= ince the connector state's `hdmi.is_limited_range` / infoframe generation s= hould be gated on HDMI mode). Worth verifying that the framework indeed ski= ps AVI infoframe generation for DVI sinks =E2=80=94 if not, the driver woul= d be writing infoframes to hardware that's in DVI mode, which would be harm= less but wasteful. --- Generated by Claude Code Patch Reviewer