From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: misc: fastrpc: Fail Audio PD init when reserved memory is missing Date: Sat, 16 May 2026 09:09:54 +1000 Message-ID: In-Reply-To: <20260515124217.20723-4-jianping.li@oss.qualcomm.com> References: <20260515124217.20723-1-jianping.li@oss.qualcomm.com> <20260515124217.20723-4-jianping.li@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Verdict: Looks good, minor observation.** The validation is correct and prevents NULL dereferences: ```c + if (!fl->cctx->remote_heap || + !fl->cctx->remote_heap->dma_addr || + !fl->cctx->remote_heap->size) { + err = -ENOMEM; + goto err; + } ``` Minor note: Checking `!fl->cctx->remote_heap->dma_addr` could theoretically be a false positive if a DMA address is legitimately 0, but in practice reserved-memory regions on ARM platforms will never map to physical address 0. This is a standard defensive check. This patch is superseded by patch 4 for mainline but is important for stable backports. The error code `-ENOMEM` is reasonable since the memory region is absent. --- --- Generated by Claude Code Patch Reviewer