From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: bridge: dw_hdmi: Call poweron/poweroff from atomic enable/disable
Date: Mon, 18 May 2026 16:41:45 +1000
Message-ID: <review-patch3-20260516183838.2024991-4-jonas@kwiboo.se>
In-Reply-To: <20260516183838.2024991-4-jonas@kwiboo.se>
References: <20260516183838.2024991-1-jonas@kwiboo.se> <20260516183838.2024991-4-jonas@kwiboo.se>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

**Status:** Clean simplification.

Removes `bridge_is_on`, `dw_hdmi_update_power()`, and the power management from `dw_hdmi_setup_rx_sense()` and `dw_hdmi_connector_force()`. The commit message correctly explains that `drm_helper_hpd_irq_event()` already handles enable/disable based on connection status.

The direct calls:
```c
-	dw_hdmi_update_power(hdmi);
+	dw_hdmi_poweroff(hdmi);
```
and
```c
-	dw_hdmi_update_power(hdmi);
+	dw_hdmi_poweron(hdmi);
```
are straightforward since the old `dw_hdmi_update_power()` just checked `disabled`/`force`/`rxsense` state that is already guaranteed by the atomic enable/disable call context.

---
Generated by Claude Code Patch Reviewer