From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: rust: driver: decouple driver private data from driver type Date: Mon, 18 May 2026 16:24:33 +1000 Message-ID: In-Reply-To: <20260517000149.3226762-4-dakr@kernel.org> References: <20260517000149.3226762-1-dakr@kernel.org> <20260517000149.3226762-4-dakr@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Large refactoring that introduces the GAT pattern across all bus driver tra= its. The key change: ```rust + type Data<'bound>: 'bound =3D (); ``` Each bus trait (`pci::Driver`, `platform::Driver`, `auxiliary::Driver`, `i2= c::Driver`, `usb::Driver`) gains this associated type with a default of `()= `. The `Registration` struct becomes generic over `D: Driver` rather than b= eing bus-specific. This is the foundational patch. The approach of defaulting `Data` to `()` a= llows incremental adoption =E2=80=94 existing drivers don't need changes un= til they want lifetime-parameterized data. --- Generated by Claude Code Patch Reviewer