From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: renesas: rz-du: Make DU reset control optional for RZ/T2H support Date: Mon, 25 May 2026 22:39:44 +1000 Message-ID: In-Reply-To: <20260519160825.4082566-4-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260519160825.4082566-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20260519160825.4082566-4-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Status: Good, minor nit** Switches from `devm_reset_control_get_shared()` to `devm_reset_control_get_optional_shared()`. The existing error handling still works correctly since `_optional` returns NULL instead of an error when no reset is present, and `reset_control_assert()`/`reset_control_deassert()` are documented to be no-ops on NULL. Minor nit: the error message `"can't get cpg reset\n"` will now only trigger for actual errors (not -ENOENT), but it might be slightly confusing since on RZ/T2H there's intentionally no reset. However, the `_optional` variant returns NULL for absent resets rather than an error, so this path only fires on genuine failures. This is fine. --- Generated by Claude Code Patch Reviewer