From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: arm64: dts: qcom: sc8280xp-arcata: Enable the eDP display Date: Mon, 25 May 2026 21:20:09 +1000 Message-ID: In-Reply-To: <20260520-surface-sp9-5g-for-next-v1-3-9df52552bf87@gmail.com> References: <20260520-surface-sp9-5g-for-next-v1-0-9df52552bf87@gmail.com> <20260520-surface-sp9-5g-for-next-v1-3-9df52552bf87@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Minor observation.** The eDP panel, PHY, and DP3 setup is correct and fol= lows the X13s pattern precisely. The removal of the `regulator-always-on` F= IXME comment from `vreg_l6b` is good =E2=80=94 with the eDP PHY now properl= y consuming this regulator (`vdda-phy-supply =3D <&vreg_l6b>`), the always-= on hack is no longer needed. However, the patch also **removes `dispcc1`** enablement: ```diff -&dispcc1 { - status =3D "okay"; -}; ``` The commit message doesn't mention or justify this removal. If the Surface = Pro 9 5G has no outputs connected to MDSS1, this is fine, but it would be h= elpful to explain this in the commit message, especially since the X13s sti= ll enables dispcc1. --- Generated by Claude Code Patch Reviewer