From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: misc: fastrpc: Expand context ID mask for DSP polling mode support Date: Mon, 25 May 2026 22:12:29 +1000 Message-ID: In-Reply-To: <20260520065047.3415790-4-ekansh.gupta@oss.qualcomm.com> References: <20260520065047.3415790-1-ekansh.gupta@oss.qualcomm.com> <20260520065047.3415790-4-ekansh.gupta@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Overall: Looks good.** The commit message clearly explains the rationale. The change from `GENMASK(11, 4)` to `GENMASK(15, 8)` shifts the context ID = to the upper byte, leaving bits [7:0] for DSP flags (async mode bit, PD typ= e). The commit message documents the bit layout well. One question worth considering: this changes the wire format of context IDs= sent to the DSP. The commit message states "This change is compatible with= polling mode and does not break non-polling behavior" =E2=80=94 this relie= s on the DSP firmware being able to handle both the old GENMASK(11,4) layou= t and the new GENMASK(15,8) layout. Since this is v11, this backward-compat= ibility question has presumably been addressed in prior review rounds. **No issues found.** --- --- Generated by Claude Code Patch Reviewer