From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/doc: Document DRM_WEDGE_RECOVERY_COLD_RESET recovery method Date: Mon, 25 May 2026 21:57:09 +1000 Message-ID: In-Reply-To: <20260520113351.171119-10-mallesh.koujalagi@intel.com> References: <20260520113351.171119-7-mallesh.koujalagi@intel.com> <20260520113351.171119-10-mallesh.koujalagi@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Good documentation. The example script is practical and the v6 improvement = (looking up the slot via `DEVPATH/slot` symlink instead of scanning all slo= ts) is a real improvement. Minor nits: - The script variables (`$DEVICE`, `$DEVPATH`) are unquoted in most uses. P= CI paths don't contain spaces so this is fine in practice, but the leading = `readlink -f /sys/$1/device` on line 1 should be `readlink -f "/sys/$1/devi= ce"` for robustness. - The `||` fallback in the script is slightly confusing: ``` DEVPATH=3D$(readlink -f /sys/$1/device 2>/dev/null || readlink -f /sys/$1) ``` If the first `readlink` fails (not a card subdirectory), it falls back to `= readlink -f /sys/$1`. This seems intentional but isn't documented. These are minor =E2=80=94 the doc serves its purpose well. --- --- Generated by Claude Code Patch Reviewer