From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: phy: rockchip: phy-rockchip-typec: Add DRM AUX bridge
Date: Mon, 25 May 2026 21:00:52 +1000
Message-ID: <review-patch3-20260521032854.103-4-kernel@airkyi.com>
In-Reply-To: <20260521032854.103-4-kernel@airkyi.com>
References: <20260521032854.103-1-kernel@airkyi.com> <20260521032854.103-4-kernel@airkyi.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

Straightforward integration of the aux bridge into the Rockchip Type-C PHY driver.

**Issue: Error check ordering**
```c
if (of_node_name_eq(child_np, "dp-port")) {
    phy = devm_phy_create(dev, child_np, &rockchip_dp_phy_ops);
    ret = drm_aux_bridge_register_from_node(dev, child_np);
} else if ...

if (ret) {
    pm_runtime_disable(dev);
    of_node_put(child_np);
    return ret;
}

if (IS_ERR(phy)) {
```

If `devm_phy_create()` succeeds but `drm_aux_bridge_register_from_node()` returns `-EPROBE_DEFER`, we return the error but the PHY remains registered (via devm). This is fine because devm will clean it up, but it means the order of checking `ret` before `IS_ERR(phy)` could mask a PHY creation failure. If `devm_phy_create` fails AND `drm_aux_bridge_register_from_node` fails, the bridge error is returned while the PHY error is lost. Consider checking `IS_ERR(phy)` first.

**Kconfig dependency:**
```
depends on DRM || DRM=n
select DRM_AUX_BRIDGE if DRM_BRIDGE
```
This is a reasonable conditional select pattern for optional DRM dependencies.

---
Generated by Claude Code Patch Reviewer