From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: misc: fastrpc: Expand context ID mask for DSP polling mode support Date: Mon, 25 May 2026 20:54:21 +1000 Message-ID: In-Reply-To: <20260521054539.128651-4-ekansh.gupta@oss.qualcomm.com> References: <20260521054539.128651-1-ekansh.gupta@oss.qualcomm.com> <20260521054539.128651-4-ekansh.gupta@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Status: Looks good, well-documented.** The commit message clearly explains *why* the mask needs to expand: with `GENMASK(11, 4)`, odd context IDs can inadvertently set bit 4 (the "async mode" bit), causing the DSP to skip polling updates. Moving to `GENMASK(15, 8)` places the 8-bit context ID cleanly into the upper byte. This is a wire-protocol change, but it's described as backward-compatible (lower bits are reserved/unused on non-polling paths). The bit layout documentation in the commit message is excellent. Has R-b from Dmitry Baryshkov. No issues. --- Generated by Claude Code Patch Reviewer