From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: moduleparam: Add DEFINE_KERNEL_PARAM_OPS macro family Date: Mon, 25 May 2026 20:11:17 +1000 Message-ID: In-Reply-To: <20260521133326.2465264-3-kees@kernel.org> References: <20260521133315.work.845-kees@kernel.org> <20260521133326.2465264-3-kees@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Introduces three macros (`DEFINE_KERNEL_PARAM_OPS`, `_NOARG`, `_FREE`) and = converts `module_param_call()` and `STANDARD_PARAM_DEF()` to use them. This= centralizes the field layout so subsequent patches only need to touch the = macro definition. The macros expand to `const struct kernel_param_ops _name =3D { ... }` with= out a trailing semicolon, so call sites write `static DEFINE_KERNEL_PARAM_O= PS(foo, ...);` =E2=80=94 consistent with other kernel `DEFINE_*` patterns. **Verdict: Clean infrastructure, no issues.** --- Generated by Claude Code Patch Reviewer