From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: rust: driver: decouple driver private data from driver type Date: Mon, 25 May 2026 19:29:13 +1000 Message-ID: In-Reply-To: <20260521233501.1191842-4-dakr@kernel.org> References: <20260521233501.1191842-1-dakr@kernel.org> <20260521233501.1191842-4-dakr@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Introduces `type Data` (later `type Data<'bound>`) as an associated type on all bus driver traits, decoupling the driver struct from the per-device data. All existing drivers set `type Data = Self` for backward compatibility. This is a large mechanical patch (22 files) but the changes are consistent. The key insight is that this decoupling allows the Data type to later carry the `'bound` lifetime without making the Driver trait itself lifetime-parameterized. One observation: the I2C adapter's `probe_callback` and `remove_callback` are updated to use `T::Data` throughout, which is correct. No issues. --- --- Generated by Claude Code Patch Reviewer