From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: firmware: qcom_scm: Migrate to generic PAS service
Date: Mon, 25 May 2026 18:55:29 +1000 [thread overview]
Message-ID: <review-patch3-20260522115936.201208-4-sumit.garg@kernel.org> (raw)
In-Reply-To: <20260522115936.201208-4-sumit.garg@kernel.org>
Patch Review
This patch refactors SCM PAS functions into internal `__qcom_scm_pas_*` / `qcom_scm_pas_*` versions plus exported wrappers, then registers them as a `qcom_pas_ops` backend.
**Transitional type casting**: Throughout this patch, there are casts like `(struct qcom_pas_context *)ctx` and `(struct qcom_scm_pas_context *)ctx`. This relies on `qcom_scm_pas_context` and `qcom_pas_context` being layout-compatible. Looking at the header definitions, they are in fact identical structs. However, this is fragile -- if either struct changes independently, these casts would silently break. This is mitigated by patch 14 which removes the old type entirely. Since this is transitional code that exists only between patches 3 and 14, this is acceptable.
**`qcom_scm_is_pas_available()` check**:
```c
static bool qcom_scm_is_pas_available(void)
{
if (!__qcom_scm_is_call_available(__scm->dev, QCOM_SCM_SVC_PIL,
QCOM_SCM_PIL_PAS_AUTH_AND_RESET))
return false;
return true;
}
```
Could be simplified to `return __qcom_scm_is_call_available(...)` but this is a style nit.
**Registration in probe, unregistration in shutdown (not remove)**: `qcom_pas_ops_register` is called in `qcom_scm_probe()` but `qcom_pas_ops_unregister()` is called in `qcom_scm_shutdown()`, not in a `remove` callback. This means if the SCM platform device is unbound (e.g., via sysfs), the ops won't be unregistered. The SCM driver has no `remove` callback at all, so this is consistent with existing behavior, but worth noting.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-25 8:55 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-22 11:59 [PATCH v7 00/15] firmware: qcom: Add OP-TEE PAS service support Sumit Garg
2026-05-22 11:59 ` [PATCH v7 01/15] arm64: dts: qcom: kodiak: Add EL2 overlay Sumit Garg
2026-05-25 8:55 ` Claude review: " Claude Code Review Bot
2026-05-22 11:59 ` [PATCH v7 02/15] firmware: qcom: Add a generic PAS service Sumit Garg
2026-05-25 8:55 ` Claude review: " Claude Code Review Bot
2026-05-22 11:59 ` [PATCH v7 03/15] firmware: qcom_scm: Migrate to " Sumit Garg
2026-05-25 8:55 ` Claude Code Review Bot [this message]
2026-05-22 11:59 ` [PATCH v7 04/15] firmware: qcom: Add a PAS TEE service Sumit Garg
2026-05-25 8:55 ` Claude review: " Claude Code Review Bot
2026-05-22 11:59 ` [PATCH v7 05/15] remoteproc: qcom_q6v5_pas: Switch over to generic PAS TZ APIs Sumit Garg
2026-05-25 8:55 ` Claude review: " Claude Code Review Bot
2026-05-22 11:59 ` [PATCH v7 06/15] remoteproc: qcom_q6v5_mss: Switch " Sumit Garg
2026-05-25 8:55 ` Claude review: " Claude Code Review Bot
2026-05-22 11:59 ` [PATCH v7 07/15] remoteproc: qcom_wcnss: " Sumit Garg
2026-05-25 8:55 ` Claude review: " Claude Code Review Bot
2026-05-22 11:59 ` [PATCH v7 08/15] remoteproc: qcom: Select QCOM_PAS generic service Sumit Garg
2026-05-25 8:55 ` Claude review: " Claude Code Review Bot
2026-05-22 11:59 ` [PATCH v7 09/15] drm/msm: Switch to generic PAS TZ APIs Sumit Garg
2026-05-25 8:55 ` Claude review: " Claude Code Review Bot
2026-05-22 11:59 ` [PATCH v7 10/15] media: qcom: " Sumit Garg
2026-05-25 8:55 ` Claude review: " Claude Code Review Bot
2026-05-22 11:59 ` [PATCH v7 11/15] media: qcom: Pass proper PAS ID to set_remote_state API Sumit Garg
2026-05-25 8:55 ` Claude review: " Claude Code Review Bot
2026-05-22 11:59 ` [PATCH v7 12/15] net: ipa: Switch to generic PAS TZ APIs Sumit Garg
2026-05-25 8:55 ` Claude review: " Claude Code Review Bot
2026-05-22 11:59 ` [PATCH v7 13/15] wifi: ath12k: " Sumit Garg
2026-05-25 8:55 ` Claude review: " Claude Code Review Bot
2026-05-22 11:59 ` [PATCH v7 14/15] firmware: qcom_scm: Remove SCM PAS wrappers Sumit Garg
2026-05-25 8:55 ` Claude review: " Claude Code Review Bot
2026-05-22 11:59 ` [PATCH v7 15/15] MAINTAINERS: Add maintainer entry for Qualcomm PAS TZ service Sumit Garg
2026-05-25 8:55 ` Claude review: " Claude Code Review Bot
2026-05-25 8:55 ` Claude review: firmware: qcom: Add OP-TEE PAS service support Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-05-04 13:05 [PATCH v5 00/16] " Sumit Garg
2026-05-04 13:05 ` [PATCH v5 03/16] firmware: qcom_scm: Migrate to generic PAS service Sumit Garg
2026-05-04 22:22 ` Claude review: " Claude Code Review Bot
2026-04-27 9:55 [PATCH v4 00/15] firmware: qcom: Add OP-TEE PAS service support Sumit Garg
2026-04-27 9:55 ` [PATCH v4 03/15] firmware: qcom_scm: Migrate to generic PAS service Sumit Garg
2026-04-28 4:49 ` Claude review: " Claude Code Review Bot
2026-03-12 6:27 [PATCH v2 00/15] firmware: qcom: Add OP-TEE PAS service support Sumit Garg
2026-03-12 6:27 ` [PATCH v2 03/15] firmware: qcom_scm: Migrate to generic PAS service Sumit Garg
2026-03-13 4:26 ` Claude review: " Claude Code Review Bot
2026-03-06 10:50 [PATCH 00/14] firmware: qcom: Add OP-TEE PAS service support Sumit Garg
2026-03-06 10:50 ` [PATCH 03/14] firmware: qcom_scm: Migrate to generic PAS service Sumit Garg
2026-03-08 22:59 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch3-20260522115936.201208-4-sumit.garg@kernel.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox