From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: fbdev: Wrap fbcon updates from vga-switcheroo in helper Date: Mon, 25 May 2026 18:52:08 +1000 Message-ID: In-Reply-To: <20260522123019.211059-4-tzimmermann@suse.de> References: <20260522123019.211059-1-tzimmermann@suse.de> <20260522123019.211059-4-tzimmermann@suse.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Creates `fb_switch_outputs()` in `fbmem.c` that wraps `fbcon_remap_all()`. The `#if defined(CONFIG_FB)` guard in `vga_switcheroo.c` is correct. I veri= fied that the `VGA_SWITCHEROO` Kconfig has `depends on (FRAMEBUFFER_CONSOLE= =3Dn || FB=3Dy)`, which guarantees that when `VGA_SWITCHEROO` is built, `CO= NFIG_FB=3Dy` (not `=3Dm`). So `#if defined(CONFIG_FB)` will always be true = when this code is reachable, and the guard serves only as a compile-time sa= feguard for when `CONFIG_FB` is entirely disabled. The removal of `#include ` and `#include ` = from `vga_switcheroo.c` is correct =E2=80=94 vga-switcheroo no longer direc= tly uses console or fbcon APIs. The function is `EXPORT_SYMBOL` which is appropriate since vga_switcheroo i= s a separate module. **No issues.** --- Generated by Claude Code Patch Reviewer