From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: ite-it66121: Select HDMI or DVI mode based on sink type Date: Mon, 25 May 2026 17:50:14 +1000 Message-ID: In-Reply-To: <20260523-it66121-fix-dvi-mode-v5-v5-3-33b4468162f9@redhat.com> References: <20260523-it66121-fix-dvi-mode-v5-v5-0-33b4468162f9@redhat.com> <20260523-it66121-fix-dvi-mode-v5-v5-3-33b4468162f9@redhat.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **This is the actual bug fix and it's correct.** ```c if (regmap_write(ctx->regmap, IT66121_HDMI_MODE_REG, connector->display_info.is_hdmi ? IT66121_HDMI_MODE_HDMI : IT66121_HDMI_MODE_DVI)) ``` Using `connector->display_info.is_hdmi` to select between HDMI mode (BIT(0)= =3D 1) and DVI mode (0) is the standard kernel pattern. The `IT66121_HDMI_= MODE_DVI` define as `0` is slightly unconventional (defining a zero constan= t) but makes the intent clear and is fine. **The connector is available at this point** because `it66121_set_mode()` (= introduced in patch 2) receives it as a parameter from `atomic_enable`, whe= re it's obtained from `drm_atomic_get_new_connector_for_encoder()`. The `di= splay_info.is_hdmi` field is populated during EDID parsing and is reliable = at enable time. **No other mode-dependent logic needs updating.** The HDMI helpers handle i= nfoframe suppression for DVI sinks internally, so no additional changes are= needed in the infoframe callbacks. --- **Summary:** Fix the `HDMI_TMDS_CHAR_RATE_MIN_HZ` build error in patch 1 (d= efine it locally as `25000000ULL` or use the literal). Everything else look= s good =E2=80=94 the HDMI helper conversion is thorough and correct, and th= e DVI fix is clean and minimal. --- Generated by Claude Code Patch Reviewer