From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/dp: Read DPCD and sink count in bridge detect() Date: Mon, 25 May 2026 17:13:07 +1000 Message-ID: In-Reply-To: <20260524-hpd-refactor-v6-3-cf3ab488dd7b@oss.qualcomm.com> References: <20260524-hpd-refactor-v6-0-cf3ab488dd7b@oss.qualcomm.com> <20260524-hpd-refactor-v6-3-cf3ab488dd7b@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Moves `msm_dp_bridge_detect()` from `dp_drm.c` to `dp_display.c` and makes it actually read DPCD/sink count instead of just returning `link_ready`. **Issue (minor):** Redundant assignment of `dp`. Both lines 1199-1200 and line 1207 assign `dp` from the same source: ```c struct msm_dp_bridge *msm_dp_bridge = to_dp_bridge(bridge); struct msm_dp *dp = msm_dp_bridge->msm_dp_display; ... dp = to_dp_bridge(bridge)->msm_dp_display; ``` The `msm_dp_bridge` local and the first `dp` assignment are dead code. Drop one or the other. **Issue (minor):** `msm_dp_aux_enable_xfers(priv->aux, false)` is never called on the success path. The function enables AUX transfers but only disables them on the pm_runtime_resume failure path (before the enable even happens). After a successful detect, AUX remains enabled until the next plug/unplug event happens to disable it. This may be intentional but is worth confirming. --- --- Generated by Claude Code Patch Reviewer