From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: arm64: dts: rockchip: Add missing hclk for RK3588 eDP0
Date: Tue, 26 May 2026 07:12:12 +1000 [thread overview]
Message-ID: <review-patch3-20260525125331.140059-4-damon.ding@rock-chips.com> (raw)
In-Reply-To: <20260525125331.140059-4-damon.ding@rock-chips.com>
Patch Review
Correctly adds `HCLK_VO1` as the third clock with name `"hclk"`:
```dts
- clocks = <&cru CLK_EDP0_24M>, <&cru PCLK_EDP0>;
- clock-names = "dp", "pclk";
+ clocks = <&cru CLK_EDP0_24M>, <&cru PCLK_EDP0>, <&cru HCLK_VO1>;
+ clock-names = "dp", "pclk", "hclk";
```
Appropriate `Fixes:` tag included. No issues.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-25 21:12 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-25 12:53 [PATCH v8 00/10] Add eDP support for RK3576 Damon Ding
2026-05-25 12:53 ` [PATCH v8 01/10] dt-bindings: display: rockchip: analogix-dp: Fix hclk as third clock for RK3588 Damon Ding
2026-05-25 16:54 ` Conor Dooley
2026-05-25 21:12 ` Claude review: " Claude Code Review Bot
2026-05-25 12:53 ` [PATCH v8 02/10] dt-bindings: display: rockchip: analogix-dp: Add per-clock descriptions Damon Ding
2026-05-25 21:12 ` Claude review: " Claude Code Review Bot
2026-05-25 12:53 ` [PATCH v8 03/10] arm64: dts: rockchip: Add missing hclk for RK3588 eDP0 Damon Ding
2026-05-25 21:12 ` Claude Code Review Bot [this message]
2026-05-25 12:53 ` [PATCH v8 04/10] arm64: dts: rockchip: Add missing hclk for RK3588 eDP1 Damon Ding
2026-05-25 21:12 ` Claude review: " Claude Code Review Bot
2026-05-25 12:53 ` [PATCH v8 05/10] drm/rockchip: analogix_dp: Enable hclk for RK3588 Damon Ding
2026-05-25 21:12 ` Claude review: " Claude Code Review Bot
2026-05-25 12:53 ` [PATCH v8 06/10] dt-bindings: display: rockchip: analogix-dp: Add support for RK3576 Damon Ding
2026-05-25 21:12 ` Claude review: " Claude Code Review Bot
2026-05-25 12:53 ` [PATCH v8 07/10] arm64: dts: rockchip: Add eDP node " Damon Ding
2026-05-25 21:12 ` Claude review: " Claude Code Review Bot
2026-05-25 12:53 ` [PATCH v8 08/10] drm/bridge: analogix_dp: Rename and simplify is_rockchip() Damon Ding
2026-05-25 21:12 ` Claude review: " Claude Code Review Bot
2026-05-25 12:53 ` [PATCH v8 09/10] drm/bridge: analogix_dp: Add support for RK3576 Damon Ding
2026-05-25 21:12 ` Claude review: " Claude Code Review Bot
2026-05-25 12:53 ` [PATCH v8 10/10] drm/rockchip: " Damon Ding
2026-05-25 21:12 ` Claude review: " Claude Code Review Bot
2026-05-25 21:12 ` Claude review: Add eDP " Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-05-27 2:43 [PATCH v9 00/10] " Damon Ding
2026-05-27 2:43 ` [PATCH v9 03/10] arm64: dts: rockchip: Add missing hclk for RK3588 eDP0 Damon Ding
2026-05-27 3:55 ` Claude review: " Claude Code Review Bot
2026-05-25 8:20 [PATCH v7 00/10] Add eDP support for RK3576 Damon Ding
2026-05-25 8:20 ` [PATCH v7 03/10] arm64: dts: rockchip: Add missing hclk for RK3588 eDP0 Damon Ding
2026-05-25 21:34 ` Claude review: " Claude Code Review Bot
2026-05-21 8:08 [PATCH v6 00/10] Add eDP support for RK3576 Damon Ding
2026-05-21 8:08 ` [PATCH v6 03/10] arm64: dts: rockchip: Add missing hclk for RK3588 eDP0 Damon Ding
2026-05-25 10:40 ` Claude review: " Claude Code Review Bot
2026-05-13 7:44 [PATCH v5 00/10] Add eDP support for RK3576 Damon Ding
2026-05-13 7:44 ` [PATCH v5 03/10] arm64: dts: rockchip: Add missing hclk for RK3588 eDP0 Damon Ding
2026-05-16 2:26 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch3-20260525125331.140059-4-damon.ding@rock-chips.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox