From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: gpu: nova-core: replace ARef<Device> with &'bound Device in SysmemFlush
Date: Wed, 27 May 2026 15:28:23 +1000
Message-ID: <review-patch3-20260525225838.276108-4-dakr@kernel.org>
In-Reply-To: <20260525225838.276108-4-dakr@kernel.org>
References: <20260525225838.276108-1-dakr@kernel.org> <20260525225838.276108-4-dakr@kernel.org>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

Straightforward simplification now that `SysmemFlush<'sys>` has a lifetime =
parameter.

```rust
-    device: ARef<device::Device>,
+    device: &'sys device::Device,
```

And in `register()`:

```rust
-        dev: &device::Device<device::Bound>,
+        dev: &'sys device::Device<device::Bound>,
```

With:

```rust
-            device: dev.into(),
+            device: dev,
```

**One observation:** The `device` field type is `&'sys device::Device` (unp=
arameterized), but the `register()` function takes `&'sys device::Device<de=
vice::Bound>`. The assignment `device: dev` works because `device::Device<d=
evice::Bound>` derefs to `device::Device` (the unparameterized form). This =
is an implicit coercion that's standard in the kernel Rust device model =E2=
=80=94 just noting it for clarity.

The `ARef` import removal is clean. No issues found.

---
Generated by Claude Code Patch Reviewer