From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/amd/display: use DisplayID panel type in dm_set_panel_type Date: Wed, 27 May 2026 15:16:43 +1000 Message-ID: In-Reply-To: <20260526030254.1460480-4-chen-yu.chen@amd.com> References: <20260526030254.1460480-1-chen-yu.chen@amd.com> <20260526030254.1460480-4-chen-yu.chen@amd.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Status: Looks good.** The patch correctly replaces the TODO comment with working code. The insert= ion point after DPCD and before the Samsung luminance heuristic gives the r= ight priority: VSDB > DPCD > DisplayID > Samsung heuristic. The mapping between the two enum spaces is correct: - `DRM_MODE_PANEL_TYPE_LCD (2)` =E2=86=92 `PANEL_TYPE_LCD (1)` from `dc_typ= es.h` - `DRM_MODE_PANEL_TYPE_OLED (1)` =E2=86=92 `PANEL_TYPE_OLED (2)` from `dc_t= ypes.h` These are different numbering spaces, and the explicit if/else-if mapping h= andles the translation correctly without assuming the values match. The LCD property exposure at the end of the function: ```c else if (link->panel_type =3D=3D PANEL_TYPE_LCD) drm_object_property_set_value(&connector->base, adev_to_drm(adev)->mode_config.panel_type_property, DRM_MODE_PANEL_TYPE_LCD); ``` is correctly placed between the OLED and UNKNOWN branches. **Note:** `PANEL_TYPE_MINILED` still falls through to `DRM_MODE_PANEL_TYPE_= UNKNOWN` in the property setting. This is pre-existing behavior, not introd= uced by this patch, but it means mini-LED panels detected via VSDB/DPCD won= 't be exposed as a distinct type to userspace. This could be a follow-up en= hancement. --- Generated by Claude Code Patch Reviewer