From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/vkms: Convert to DRM's vblank timer Date: Wed, 27 May 2026 14:49:45 +1000 Message-ID: In-Reply-To: <20260526133123.691465-4-w15303746062@163.com> References: <20260526133123.691465-1-w15303746062@163.com> <20260526133123.691465-4-w15303746062@163.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Cherry-pick of upstream `02e2681ffe1addde1fc8c35d05657b16bfa79613`. Removes vkms's open-coded hrtimer vblank simulation and replaces it with the generic infrastructure from patches 1-2. The old `vkms_vblank_simulate()` hrtimer callback becomes `vkms_crtc_handle_vblank_timeout()` (returning `bool` instead of `enum hrtimer_restart`), keeping only the vkms-specific compositor scheduling logic. The hrtimer forwarding, overrun handling, and timer lifecycle are now in the DRM core. The vkms-specific `atomic_flush` is kept (not replaced with the generic one from patch 2) because vkms has additional composer/CRC logic there. This is correct. Removes `vblank_hrtimer` and `period_ns` from `struct vkms_output`. **No issues.** --- Generated by Claude Code Patch Reviewer