From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: rust: always inline some init methods Date: Thu, 28 May 2026 12:22:00 +1000 Message-ID: In-Reply-To: <20260527-nova-exports-v2-3-06de4c556d55@nvidia.com> References: <20260527-nova-exports-v2-0-06de4c556d55@nvidia.com> <20260527-nova-exports-v2-3-06de4c556d55@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Adds `#[inline(always)]` to 8 methods across 4 files: - `Box::write_init`, `Box::write_pin_init` in `kbox.rs` - `InPlaceInit::pin_init` in `init.rs` - `UniqueArc::write_init`, `UniqueArc::write_pin_init` in `arc.rs` - `Opaque::ffi_init`, `Opaque::try_ffi_init`, `Opaque::pin_init` in `types.rs` These are all thin wrapper methods that forward to inner initialization logic. Forcing inlining is justified both for optimization (avoiding monomorphization explosion of trivial wrappers) and for the symbol length constraint. **No issues.** Same maintainer coordination needed as patch 2. --- Generated by Claude Code Patch Reviewer