From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/amdgpu: vkms: Set DRM_VBLANK_FLAG_SIMULATED Date: Thu, 28 May 2026 12:19:15 +1000 Message-ID: In-Reply-To: <20260527133917.207150-4-tzimmermann@suse.de> References: <20260527133917.207150-1-tzimmermann@suse.de> <20260527133917.207150-4-tzimmermann@suse.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Simple, mechanical conversion of amdgpu's internal VKMS (virtual display) f= rom `drm_vblank_init()` to `drmm_vblank_init()` with `DRM_VBLANK_FLAG_SIMUL= ATED`. ```c - r =3D drm_vblank_init(adev_to_drm(adev), adev->mode_info.num_crtc); + r =3D drmm_vblank_init(adev_to_drm(adev), adev->mode_info.num_crtc, + DRM_VBLANK_FLAG_SIMULATED); ``` Correct =E2=80=94 amdgpu's VKMS mode uses software vblank timers, not hardw= are interrupts. --- Generated by Claude Code Patch Reviewer