From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: fbdev: Wrap fbcon updates from vga-switcheroo in helper Date: Thu, 28 May 2026 12:12:51 +1000 Message-ID: In-Reply-To: <20260527151551.258659-4-tzimmermann@suse.de> References: <20260527151551.258659-1-tzimmermann@suse.de> <20260527151551.258659-4-tzimmermann@suse.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Clean. `fb_switch_outputs()` is a thin wrapper around `fbcon_remap_all()`, = correctly placed in `fbmem.c` and exported for vga-switcheroo's use. **Kconfig change**: The dependency changes from `(FRAMEBUFFER_CONSOLE=3Dn |= | FB=3Dy)` to `FB=3Dy`. This is slightly more restrictive =E2=80=94 previou= sly vga-switcheroo could be built if FRAMEBUFFER_CONSOLE was disabled even = without FB=3Dy, but that seems like a pathological configuration. With the = new `fb_switch_outputs` living in fbmem.c (part of FB), requiring `FB=3Dy` = is correct. The `#if defined(CONFIG_FB)` guard in `vga_switcheroo.c` is technically red= undant with the Kconfig `depends on FB=3Dy`, but it's harmless belt-and-sus= penders and was flagged in v3 review feedback from Geert. Removal of `#include ` and `#include ` from= vga_switcheroo.c is correct =E2=80=94 those interfaces are no longer used = directly. --- Generated by Claude Code Patch Reviewer