From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/virtio: Open-code drm_simple_encoder_init() Date: Thu, 04 Jun 2026 15:05:00 +1000 Message-ID: In-Reply-To: <20260531073532.8609-4-namanarora029@gmail.com> References: <20260531073532.8609-1-namanarora029@gmail.com> <20260531073532.8609-4-namanarora029@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Correctness: OK, with a pre-existing nit** The transformation itself is correct. However, note that both the original and patched code ignore the return value: ```c drm_encoder_init(dev, encoder, &virtio_gpu_drm_encoder_funcs, DRM_MODE_ENCODER_VIRTUAL, NULL); ``` `drm_encoder_init()` returns `int`, and `vgdev_output_init()` checks errors from other init calls. The original `drm_simple_encoder_init()` also returned `int` and was similarly ignored. This is a **pre-existing issue**, not introduced by this patch, but could be mentioned as a follow-up cleanup opportunity. Otherwise reviewed-by worthy. --- Generated by Claude Code Patch Reviewer