From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: nouveau/gsp/rm/alloc: Cleanup IS_ERR_OR_NULL usage
Date: Thu, 04 Jun 2026 14:22:54 +1000 [thread overview]
Message-ID: <review-patch3-20260601095403.228220-4-zenghongling@kylinos.cn> (raw)
In-Reply-To: <20260601095403.228220-4-zenghongling@kylinos.cn>
Patch Review
**Already applied on drm-next.** The change is correct:
```c
rpc = nvkm_gsp_rpc_get(gsp, NV_VGPU_MSG_FUNCTION_FREE, sizeof(*rpc));
- if (WARN_ON(IS_ERR_OR_NULL(rpc)))
+ if (WARN_ON(IS_ERR(rpc)))
return -EIO;
```
`nvkm_gsp_rpc_get()` wraps `r535_gsp_rpc_get()`, which returns `ERR_CAST(rpc)` on error or `rpc->data` on success — never NULL.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-06-04 4:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-01 9:53 [PATCH v2 0/5] nouveau/gsp: Clean up IS_ERR vs IS_ERR_OR_NULL usage Hongling Zeng
2026-06-01 9:53 ` [PATCH v2 1/5] nouveau/gsp/rpc: Document RPC function return value contracts Hongling Zeng
2026-06-04 4:22 ` Claude review: " Claude Code Review Bot
2026-06-01 9:54 ` [PATCH v2 2/5] nouveau/gsp/rpc: Cleanup incorrect IS_ERR_OR_NULL in rpc.c Hongling Zeng
2026-06-04 4:22 ` Claude review: " Claude Code Review Bot
2026-06-01 9:54 ` [PATCH v2 3/5] nouveau/gsp/rm/alloc: Cleanup IS_ERR_OR_NULL usage Hongling Zeng
2026-06-04 4:22 ` Claude Code Review Bot [this message]
2026-06-01 9:54 ` [PATCH v2 4/5] nouveau/gsp/rm/bar: " Hongling Zeng
2026-06-04 4:22 ` Claude review: " Claude Code Review Bot
2026-06-01 9:54 ` [PATCH v2 5/5] nouveau/gsp: Cleanup IS_ERR_OR_NULL in nvkm_gsp_rpc_rd() Hongling Zeng
2026-06-04 4:22 ` Claude review: " Claude Code Review Bot
2026-06-04 4:22 ` Claude review: nouveau/gsp: Clean up IS_ERR vs IS_ERR_OR_NULL usage Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch3-20260601095403.228220-4-zenghongling@kylinos.cn \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox