From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: iio: light: lm3533-als: Remove redundant pdata helpers
Date: Thu, 04 Jun 2026 13:59:54 +1000
Message-ID: <review-patch3-20260601151831.76350-4-clamor95@gmail.com>
In-Reply-To: <20260601151831.76350-4-clamor95@gmail.com>
References: <20260601151831.76350-1-clamor95@gmail.com> <20260601151831.76350-4-clamor95@gmail.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

Straightforward inlining of `lm3533_als_set_input_mode` and `lm3533_als_set_resistor` into `lm3533_als_setup`. The `dev_err_probe` conversion is a nice touch.

Minor: there's a stale extra blank line after the first `dev_err_probe` call:

```c
	if (ret)
		return dev_err_probe(dev, ret, "failed to set input mode %d\n",
				     pdata->pwm_mode);

                                           <-- extra blank line
	/* ALS input is always high impedance in PWM-mode. */
```

**No blocking issues.**

---
Generated by Claude Code Patch Reviewer