From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: platform/surface: SAM: Add support for Surface Pro 12in Date: Sat, 16 May 2026 09:57:52 +1000 Message-ID: In-Reply-To: References: X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Adds a SAM node group and OF match entry for the Surface Pro 12in: ```c +static const struct software_node *ssam_node_group_sp12in[] = { + &ssam_node_root, + &ssam_node_hub_kip, + &ssam_node_tmp_sensors, + &ssam_node_hid_kip_keyboard, + &ssam_node_hid_sam_penstash, + &ssam_node_hid_kip_touchpad, + &ssam_node_hid_kip_fwupd, + &ssam_node_pos_tablet_switch, + NULL, +}; ``` The commit message explains the deliberate omission of battery and charger info nodes to avoid conflicts with other drivers. The node group is similar to SP11 (`ssam_node_group_sp11`) but without battery-related nodes. The OF match entry correctly uses the compatible from the DTS: ```c + { .compatible = "microsoft,surface-pro-12in", (void *)ssam_node_group_sp12in }, ``` **Minor nit:** The comment says `/* Surface Pro 12in First Edition (ARM/QCOM) */` while other entries use shorter names like `/* Surface Pro 11 (ARM/QCOM) */`. Consistent, but "First Edition" is a bit verbose for a comment. Not blocking. **No functional issues.** --- --- Generated by Claude Code Patch Reviewer