From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Re: [PATCH 03/35] fbdev: sisfb: Use safer strscpy() instead of strcpy() Date: Tue, 28 Apr 2026 15:38:39 +1000 Message-ID: In-Reply-To: References: <20260425065926.1091168-1-aichao@kylinos.cn> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Files:** `sis/sis_main.c` =E2=80=94 8 replacements The 7 `ivideo->myid` replacements (e.g., `"SiS 730"` =E2=86=92 `char myid[4= 0]`) are trivially safe. **Worth noting:** The `strbuf1` case is qualitatively different from the re= st of the series: ```c if(strlen(name) <=3D 19) { strscpy(strbuf1, name); ``` Here `strbuf1` is `char[20]` and the source is a runtime variable `name`, n= ot a compile-time literal. The `strlen(name) <=3D 19` guard means the origi= nal `strcpy()` was already safe, but `strscpy()` adds defense-in-depth. Thi= s is genuinely a different pattern from copying a known-short literal into = a known-large buffer =E2=80=94 the commit message should acknowledge this r= ather than claiming all changes are identical. **Reviewed-by: acceptable with nit** --- --- Generated by Claude Code Patch Reviewer