Claude review: Re: [PATCH v3 3/3] arm64: dts: qcom: sm6125-xiaomi-laurel-sprout: Enable MDSS and add panel

[Claude Code Review Bot <claude-review@example.com>]

Patch Review

**Potential bug: VCI regulator voltage mismatch (lines 809-820 of mbox):**

```dts
panel_vci_3p0: regulator-panel-vci {
	compatible = "regulator-fixed";
	regulator-name = "panel_vci_3p0";
	regulator-min-microvolt = <1800000>;
	regulator-max-microvolt = <1800000>;
```

The node and regulator are named `panel_vci_3p0` implying 3.0V, but the voltage is set to 1800000 (1.8V). Either the name is misleading or the voltage is wrong. This should be clarified — if the panel VCI truly runs at 1.8V, the label should be renamed to `panel_vci_1p8` to avoid confusion. If it should actually be 3.0V (3000000 µV), the voltage values need fixing. VCI for AMOLED panels is typically 3.0V–3.3V, so this looks like it might be a real bug.

**Minor: Extra blank line (line 863 of mbox):**

```dts
&mdss_dsi0_out {
	data-lanes = <0 1 2 3>;
	remote-endpoint = <&panel_in>;
};


&mdss_dsi0_phy {
```

There's an extra blank line between `&mdss_dsi0_out` and `&mdss_dsi0_phy`. Minor style nit.

**Observation: `regulator-boot-on` present on both regulators.** This is fine for panels that need to be powered at boot for a smooth transition from the bootloader's display.

**Observation: No `vin-supply` on `panel_vci_3p0`.** The VDDI regulator has `vin-supply = <&vreg_l9a>` but the VCI regulator has no `vin-supply`. This may be fine if VCI is powered directly from battery or another always-on rail, but it's worth confirming.

**Summary of required fixes:**
1. Fix "Samsubng" typo in MODULE_DESCRIPTION (patch 2)
2. Clean up `samsungp` in the display mode variable name (patch 2)
3. Verify/fix the `panel_vci_3p0` voltage — 1.8V vs 3.0V mismatch (patch 3)
4. Clarify the `MIPI_DSI_MODE_LPM` behavior — it's never set initially but gets added after the first backlight update (patch 2)

---
Generated by Claude Code Patch Reviewer