From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Re: [PATCH v3 3/3] arm64: dts: qcom: sm6125-xiaomi-laurel-sprout: Enable MDSS and add panel
Date: Fri, 13 Mar 2026 14:15:08 +1000
Message-ID: <review-patch3-vjpnt6xefyssqlaivlvhtizlnlw7gfsmwtexcc7ukccwhgfeet@egtg6oe6za4c>
In-Reply-To: <vjpnt6xefyssqlaivlvhtizlnlw7gfsmwtexcc7ukccwhgfeet@egtg6oe6za4c>
References: <20260312-panel-patches-v3-0-6ed8c006d0be@gmail.com> <vjpnt6xefyssqlaivlvhtizlnlw7gfsmwtexcc7ukccwhgfeet@egtg6oe6za4c>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

**Potential bug: VCI regulator voltage mismatch (lines 809-820 of mbox):**

```dts
panel_vci_3p0: regulator-panel-vci {
	compatible =3D "regulator-fixed";
	regulator-name =3D "panel_vci_3p0";
	regulator-min-microvolt =3D <1800000>;
	regulator-max-microvolt =3D <1800000>;
```

The node and regulator are named `panel_vci_3p0` implying 3.0V, but the vol=
tage is set to 1800000 (1.8V). Either the name is misleading or the voltage=
 is wrong. This should be clarified =E2=80=94 if the panel VCI truly runs a=
t 1.8V, the label should be renamed to `panel_vci_1p8` to avoid confusion. =
If it should actually be 3.0V (3000000 =C2=B5V), the voltage values need fi=
xing. VCI for AMOLED panels is typically 3.0V=E2=80=933.3V, so this looks l=
ike it might be a real bug.

**Minor: Extra blank line (line 863 of mbox):**

```dts
&mdss_dsi0_out {
	data-lanes =3D <0 1 2 3>;
	remote-endpoint =3D <&panel_in>;
};


&mdss_dsi0_phy {
```

There's an extra blank line between `&mdss_dsi0_out` and `&mdss_dsi0_phy`. =
Minor style nit.

**Observation: `regulator-boot-on` present on both regulators.** This is fi=
ne for panels that need to be powered at boot for a smooth transition from =
the bootloader's display.

**Observation: No `vin-supply` on `panel_vci_3p0`.** The VDDI regulator has=
 `vin-supply =3D <&vreg_l9a>` but the VCI regulator has no `vin-supply`. Th=
is may be fine if VCI is powered directly from battery or another always-on=
 rail, but it's worth confirming.

**Summary of required fixes:**
1. Fix "Samsubng" typo in MODULE_DESCRIPTION (patch 2)
2. Clean up `samsungp` in the display mode variable name (patch 2)
3. Verify/fix the `panel_vci_3p0` voltage =E2=80=94 1.8V vs 3.0V mismatch (=
patch 3)
4. Clarify the `MIPI_DSI_MODE_LPM` behavior =E2=80=94 it's never set initia=
lly but gets added after the first backlight update (patch 2)

---
Generated by Claude Code Patch Reviewer