From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/dp: add dp_display_get_panel() to initialize DP panel Date: Sun, 12 Apr 2026 10:16:18 +1000 Message-ID: In-Reply-To: <20260410-msm-dp-mst-v4-30-b20518dea8de@oss.qualcomm.com> References: <20260410-msm-dp-mst-v4-0-b20518dea8de@oss.qualcomm.com> <20260410-msm-dp-mst-v4-30-b20518dea8de@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Bug =E2=80=94 wrong variable in IS_ERR check**: ```c + dp_panel =3D msm_dp_panel_get(&dp->msm_dp_display.pdev->dev, dp->aux, dp-= >link, + dp->link_base, dp->mst2link_base, dp->mst3link_base, + dp->pixel_base[0]); + + if (IS_ERR(dp->panel)) { + DRM_ERROR("failed to initialize panel\n"); + return NULL; + } ``` This checks `IS_ERR(dp->panel)` =E2=80=94 the *existing* SST panel =E2=80= =94 instead of `IS_ERR(dp_panel)` =E2=80=94 the *newly allocated* MST panel= . If `msm_dp_panel_get()` returns an error pointer, this code will skip the= error check and proceed to dereference the error pointer in the `memcpy` b= elow, causing a kernel crash. This is a clear bug that must be fixed before= merge. --- Generated by Claude Code Patch Reviewer