From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dyndbg: add DYNAMIC_DEBUG_CLASSMAP_USE_(dd_class_name, offset) Date: Sat, 14 Mar 2026 07:00:27 +1000 Message-ID: In-Reply-To: <20260313132103.2529746-32-jim.cromie@gmail.com> References: <20260313132103.2529746-1-jim.cromie@gmail.com> <20260313132103.2529746-32-jim.cromie@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Self-described as untested.** The offset arithmetic in `ddebug_find_valid= _class` (`*class_id =3D idx + cli->map->base - cli->offset`) needs careful = verification. The author suggests dropping if too speculative =E2=80=94 I a= gree this should be deferred until tested. --- Generated by Claude Code Patch Reviewer