From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/dp: initialize dp_mst module for each DP MST controller Date: Sun, 12 Apr 2026 10:16:19 +1000 Message-ID: In-Reply-To: <20260410-msm-dp-mst-v4-33-b20518dea8de@oss.qualcomm.com> References: <20260410-msm-dp-mst-v4-0-b20518dea8de@oss.qualcomm.com> <20260410-msm-dp-mst-v4-33-b20518dea8de@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Introduces `dp_mst_drm.c` with core MST structures and initialization: ```c +struct msm_dp_mst { + struct drm_dp_mst_topology_mgr mst_mgr; + struct msm_dp *msm_dp; + struct drm_dp_aux *dp_aux; + u32 max_streams; + struct mutex mst_lock; +}; ``` The `msm_dp_mst_init()` function correctly calls `drm_dp_mst_topology_mgr_init()` and wires up the MST manager. The `memset` before init is unnecessary since `devm_kzalloc` already zeroes: ```c + msm_dp_mst = devm_kzalloc(dev->dev, sizeof(*msm_dp_mst), GFP_KERNEL); + ... + memset(&msm_dp_mst->mst_mgr, 0, sizeof(msm_dp_mst->mst_mgr)); ``` --- Generated by Claude Code Patch Reviewer