From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/vkms: Introduce configfs for dynamic connector creation
Date: Thu, 23 Apr 2026 07:30:19 +1000
Message-ID: <review-patch35-20260422-vkms-all-config-v4-35-dbb52e9aadc3@bootlin.com>
In-Reply-To: <20260422-vkms-all-config-v4-35-dbb52e9aadc3@bootlin.com>
References: <20260422-vkms-all-config-v4-0-dbb52e9aadc3@bootlin.com> <20260422-vkms-all-config-v4-35-dbb52e9aadc3@bootlin.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

**Bug: rollback outside lock scope.** In `connector_enabled_store()`:

```c
scoped_guard(mutex, &connector->dev->lock) {
    // ...
    if (!vkms_config_is_valid(connector->dev->config)) {
        count = -EINVAL;
        goto rollback;
    }
    // ...
}
return count;

rollback:
    vkms_config_connector_set_enabled(connector_cfg, was_enabled);
    return count;
```

The `goto rollback` exits the `scoped_guard` block, releasing the mutex. The rollback then calls `vkms_config_connector_set_enabled()` **without the lock held**. This is a data race. Move the rollback inside the scoped_guard, or restructure to avoid the goto.

**Style:** Uses `//` comments in several places; should be `/* */`.

---
Generated by Claude Code Patch Reviewer