From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/dp: add connector abstraction for DP MST Date: Sun, 12 Apr 2026 10:16:20 +1000 Message-ID: In-Reply-To: <20260410-msm-dp-mst-v4-36-b20518dea8de@oss.qualcomm.com> References: <20260410-msm-dp-mst-v4-0-b20518dea8de@oss.qualcomm.com> <20260410-msm-dp-mst-v4-36-b20518dea8de@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Adds the MST connector abstraction with `msm_dp_mst_add_connector()` callba= ck for the topology manager. The connector correctly calls `drm_connector_d= ynamic_init()` for hotplugged MST connectors. The `msm_dp_mst_atomic_best_encoder()` logic has a two-pass approach: first= find an existing bridge assigned to this connector, then find a free bridg= e. This is correct for MST encoder assignment. Minor: In `msm_dp_mst_add_connector()`, if `drm_connector_attach_encoder()`= fails, the `mst_conn` is freed but the connector was already initialized w= ith `drm_connector_dynamic_init()` =E2=80=94 the connector should be cleane= d up via `drm_connector_cleanup()` first to avoid leaking DRM resources. --- Generated by Claude Code Patch Reviewer