From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/atomic: Call complete_signaling only if prepare_signaling is done Date: Wed, 11 Feb 2026 16:31:47 +1000 Message-ID: In-Reply-To: <20260210-atomic-v9-4-525c88fd2402@intel.com> References: <20260210-atomic-v9-0-525c88fd2402@intel.com> <20260210-atomic-v9-4-525c88fd2402@intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Mailer: Claude Code Patch Reviewer Patch Review **Issues:** ```c - unsigned int i, j, num_fences; + unsigned int i, j, num_fences = 0; ``` - **Correct Fix**: This initializes `num_fences` to handle the new early error paths ```c out: - complete_signaling(dev, state, fence_state, num_fences, !ret); + if (num_fences) + complete_signaling(dev, state, fence_state, num_fences, !ret); ``` - **Logic Issue**: `fence_state` may be uninitialized if we goto `out` before `prepare_signaling`. This check doesn't protect against using uninitialized `fence_state` pointer. - **Should Check**: `if (fence_state)` might be more robust, though checking `num_fences` is probably equivalent if prepare_signaling is the only place it's set. --- Generated by Claude Code Patch Reviewer