Claude review: pmdomain: bcm: bcm2835-power: Increase ASB control timeout

[Claude Code Review Bot <claude-review@example.com>]

Patch Review

> -	start = ktime_get_ns();
> -
>  	/* Enable the module's async AXI bridges. */
>  	if (enable) {
>  		val = readl(base + reg) & ~ASB_REQ_STOP;
> @@ -176,9 +174,10 @@
>  	}
>  	writel(PM_PASSWORD | val, base + reg);
>  
> +	start = ktime_get_ns();
>  	while (!!(readl(base + reg) & ASB_ACK) == enable) {
>  		cpu_relax();
> -		if (ktime_get_ns() - start >= 1000)
> +		if (ktime_get_ns() - start >= 5000)
>  			return -ETIMEDOUT;
>  	}

Moving the timestamp after the `writel()` is a good change -- the previous placement counted the write latency against the timeout budget. The increase from 1us to 5us is modest and, as the commit message says, negligible in a power domain transition context.

The commit message states this fixes intermittent "Failed to disable ASB master for v3d" errors on BCM2711 during runtime PM suspend. Was this timeout value determined empirically, and has 5us been sufficient in all testing? The concern is whether this is papering over a deeper issue versus being a genuine timing margin fix. That said, the change itself is correct.

No issues found.

---
Generated by Claude Code Patch Reviewer