From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: nova-core: gsp: remove unneeded sequencer trait Date: Tue, 17 Feb 2026 15:48:07 +1000 Message-ID: In-Reply-To: <20260217-nova-misc-v3-4-b4e2d45eafbc@nvidia.com> References: <20260217-nova-misc-v3-0-b4e2d45eafbc@nvidia.com> <20260217-nova-misc-v3-4-b4e2d45eafbc@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review The `GspSeqCmdRunner` trait with its single method `fn run(&self, sequencer: &GspSequencer<'_>) -> Result` is removed in favor of inherent `run` methods on each payload type and on `GspSeqCmd`. Since the trait was never used for dynamic dispatch or generic code, the inherent methods work identically. > -/// Trait for running sequencer commands. > -pub(crate) trait GspSeqCmdRunner { > - fn run(&self, sequencer: &GspSequencer<'_>) -> Result; > -} > - > -impl GspSeqCmdRunner for fw::RegWritePayload { > +impl fw::RegWritePayload { No issues found. --- Generated by Claude Code Patch Reviewer