From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: arm64: dts: ti: add GPU node Date: Fri, 27 Feb 2026 14:48:58 +1000 Message-ID: In-Reply-To: <20260224-gpu_dts-v1-4-cc5ddffe140c@ti.com> References: <20260224-gpu_dts-v1-0-cc5ddffe140c@ti.com> <20260224-gpu_dts-v1-4-cc5ddffe140c@ti.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Author:** Michael Walle (carried by Antonios Christidis) Adds the BXS-4 GPU node for J722S/AM62P in the shared common-main dtsi. **Vague subject line:** `"arm64: dts: ti: add GPU node"` doesn't specify which SoC. It should be something like `"arm64: dts: ti: k3-am62p-j722s: Add GPU node"` to match the convention of the other patches in this series. ```dts gpu: gpu@fd80000 { compatible = "ti,am62p-gpu", "img,img-bxs-4-64", "img,img-rogue"; reg = <0x00 0x0fd80000 0x00 0x80000>; clocks = <&k3_clks 237 3>; clock-names = "core"; interrupts = ; power-domains = <&k3_pds 237 TI_SCI_PD_EXCLUSIVE>, <&k3_pds 242 TI_SCI_PD_EXCLUSIVE>; power-domain-names = "a", "b"; }; ``` **Inconsistencies compared to patches 1 and 3:** 1. **Missing `assigned-clocks` / `assigned-clock-rates`**: Patches 1 and 3 both set these to configure the GPU clock rate. If the AM62P/J722S GPU needs a specific clock rate to function, these should be added. If the default is acceptable, the cover letter or commit message should explain why this node differs. 2. **Missing `dma-coherent`**: Patches 1 and 3 include `dma-coherent`. If AM62P/J722S doesn't support hardware-managed cache coherency for the GPU, this omission is correct, but it should be documented in the commit message. These differences are likely hardware-specific and intentional, but they should be explicitly noted. --- --- Generated by Claude Code Patch Reviewer