From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: accel/qda: Add built-in compute CB bus for QDA and integrate with IOMMU Date: Tue, 24 Feb 2026 18:20:11 +1000 Message-ID: In-Reply-To: <20260224-qda-firstpost-v1-4-fe46a9c1a046@oss.qualcomm.com> References: <20260224-qda-firstpost-v1-0-fe46a9c1a046@oss.qualcomm.com> <20260224-qda-firstpost-v1-4-fe46a9c1a046@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Adds a custom bus type `qda_cb_bus_type` and modifies `drivers/iommu/iommu.= c` to include it. - **Core IOMMU modification**: Adding a driver-specific bus type to the glo= bal `iommu_buses[]` array in `drivers/iommu/iommu.c` is a significant cross= -subsystem change. This requires buy-in from IOMMU maintainers (Joerg Roede= l, Will Deacon, Robin Murphy). ```c +#ifdef CONFIG_DRM_ACCEL_QDA_COMPUTE_BUS + &qda_cb_bus_type, +#endif ``` - Dmitry asked: "Why? What is the actual problem that you are trying to sol= ve?" and "there is nothing QDA-specific in this patch. Please explain, why = the bus is QDA-specific? Can we generalize it?" =E2=80=94 valid questions. = If the existing `fastrpc` driver is being reworked to not need custom bus m= anipulation (per Dmitry's comment about iommu-map improvements), this entir= e approach may be unnecessary. - The header `include/linux/qda_compute_bus.h` uses a QDA-specific name for= what might be a generic concept. If this must exist, it should be under a = more generic name. - The `Makefile` still has missing newline at EOF. --- Generated by Claude Code Patch Reviewer