From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/dsi: Add DSI PHY configuration on SC8280XP Date: Fri, 27 Feb 2026 14:04:46 +1000 Message-ID: In-Reply-To: <20260225054525.6803-5-mitltlatltl@gmail.com> References: <20260225054525.6803-1-mitltlatltl@gmail.com> <20260225054525.6803-5-mitltlatltl@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Adds the `of_device_id` entry mapping the SC8280XP DSI PHY to the SA8775P configuration: ```c + { .compatible = "qcom,sc8280xp-dsi-phy-5nm", + .data = &dsi_phy_5nm_8775p_cfgs }, ``` The commit message explains the rationale (same DSI version v2.5.1, confirmed via register value from Windows). The justification is reasonable. Inserted in alphabetical order. No issues. Note: No driver-side patch is needed for the DSI controller compatible `qcom,sc8280xp-dsi-ctrl` since the DTS uses the fallback `qcom,mdss-dsi-ctrl`. --- --- Generated by Claude Code Patch Reviewer