From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: gpu: nova-core: gsp: add checking oversized commands
Date: Tue, 03 Mar 2026 13:34:47 +1000
Message-ID: <review-patch4-20260302-cmdq-continuation-v4-4-c011f15aad58@nvidia.com>
In-Reply-To: <20260302-cmdq-continuation-v4-4-c011f15aad58@nvidia.com>
References: <20260302-cmdq-continuation-v4-0-c011f15aad58@nvidia.com> <20260302-cmdq-continuation-v4-4-c011f15aad58@nvidia.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

Adds the `GSP_MSG_QUEUE_ELEMENT_SIZE_MAX` constant (65536 = 16 pages) and a guard in `allocate_command` to reject commands that exceed this limit:

```rust
if size_of::<GspMsgElement>() + size > GSP_MSG_QUEUE_ELEMENT_SIZE_MAX {
    return Err(EMSGSIZE);
}
```

This is correct. The check is placed before the poll-wait, which avoids a pointless 1-second timeout for commands that can never fit. The constant is properly sourced from the bindings.

---
Generated by Claude Code Patch Reviewer