From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: net: change sock.sk_ino and sock_i_ino() to u64 Date: Wed, 04 Mar 2026 08:15:03 +1000 Message-ID: In-Reply-To: <20260302-iino-u64-v2-4-e5388800dae0@kernel.org> References: <20260302-iino-u64-v2-0-e5388800dae0@kernel.org> <20260302-iino-u64-v2-4-e5388800dae0@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review This patch correctly widens `sock.sk_ino` and `sock_i_ino()` return type. The format string changes across 20 networking files are mechanical and correct. **Observations**: - The `procname` buffer in CAN BCM is 32 bytes -- sufficient for decimal u64 (max 20 digits). No buffer overflow. - The diag module parameter changes from `int sk_ino` to `u64 sk_ino` are important -- `int` was already truncating on 64-bit! So this is also a bugfix for 64-bit: ```c - u32 portid, u32 seq, u32 flags, int sk_ino) + u32 portid, u32 seq, u32 flags, u64 sk_ino) ``` - The commit message correctly notes that UAPI diag structures (`idiag_inode`, `udiag_ino`, etc.) are `__u32` and will truncate, preserving existing behavior. - The `struct sock` packing impact on 32-bit is not discussed. `sk_ino` sits between `sk_max_ack_backlog` (u32) and `sk_peer_lock` (spinlock_t). Widening it from 4 to 8 bytes on 32-bit could introduce padding. This is probably minor given that `struct sock` is already large, but worth noting. --- Generated by Claude Code Patch Reviewer