From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: vt: Calculate font-buffer size with vc_font_size() Date: Tue, 03 Mar 2026 13:19:14 +1000 Message-ID: In-Reply-To: <20260302141255.518657-5-tzimmermann@suse.de> References: <20260302141255.518657-1-tzimmermann@suse.de> <20260302141255.518657-5-tzimmermann@suse.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Adds `vc_font_pitch()` and `vc_font_size()` inline helpers. Removes the `CALC_FONTSZ` macro and the `pitch <= 0` check in `fbcon_resize()`. The removal of the `pitch <= 0` check is safe because `vc_font_pitch()` uses `DIV_ROUND_UP(font->width, 8)` which returns 0 only if `width == 0`, and `vc_font_size()` then returns 0. The subsequent `if (!size || ...)` check catches this. No issues. --- Generated by Claude Code Patch Reviewer