From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/tyr: set DMA mask using GPU physical address Date: Tue, 03 Mar 2026 12:48:18 +1000 Message-ID: In-Reply-To: <20260302232500.244489-5-deborah.brouwer@collabora.com> References: <20260302232500.244489-1-deborah.brouwer@collabora.com> <20260302232500.244489-5-deborah.brouwer@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Author:** Beata Michalska Sets the DMA mask during probe based on `gpu_info.pa_bits()`. ```rust + // SAFETY: No concurrent DMA allocations or mappings can be made because + // the device is still being probed and therefore isn't being used by + // other threads of execution. + unsafe { pdev.dma_set_mask_and_coherent(DmaMask::try_new(gpu_info.pa_bits())?)? }; ``` The safety comment is appropriate for the probe-time context. Also removes `#[expect(dead_code)]` from `pa_bits()` since it's now used. No issues. --- Generated by Claude Code Patch Reviewer