From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: gpu: nova-core: gsp: make `Cmdq` a pinned type
Date: Thu, 05 Mar 2026 13:53:00 +1000
Message-ID: <review-patch4-20260304-cmdq-locking-v3-4-a6314b708850@nvidia.com>
In-Reply-To: <20260304-cmdq-locking-v3-4-a6314b708850@nvidia.com>
References: <20260304-cmdq-locking-v3-0-a6314b708850@nvidia.com> <20260304-cmdq-locking-v3-4-a6314b708850@nvidia.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

Mechanical change to make `Cmdq` a pinned type, required for the `Mutex` in patch 5.

The `#[pin_data]` annotation and `#[pin]` on the `cmdq` field are correct. The `new()` method changes from returning `Result<Cmdq>` to `impl PinInit<Self, Error>`, and construction uses `try_pin_init!` with `<-` for pin-init.

The caller change from `cmdq: Cmdq::new(dev)?` to `cmdq <- Cmdq::new(dev)` is the correct pin-init syntax.

The change from `fw::GspArgumentsCached::new(cmdq)` to `fw::GspArgumentsCached::new(&cmdq)` (line 619) is needed because `cmdq` is now behind a pin reference rather than being moved.

No issues.

---
Generated by Claude Code Patch Reviewer