From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dt-bindings: display: imx: Add i.MX94 DCIF Date: Thu, 05 Mar 2026 13:34:49 +1000 Message-ID: In-Reply-To: <20260304-dcif-upstreaming-v8-4-bec5c047edd4@oss.nxp.com> References: <20260304-dcif-upstreaming-v8-0-bec5c047edd4@oss.nxp.com> <20260304-dcif-upstreaming-v8-4-bec5c047edd4@oss.nxp.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review The binding looks well-structured. Three interrupts for three CPU domains, three clocks (apb, axi, pix), a power domain, and a single output port. One minor observation: the `required:` property list is missing from the YAML. Looking at the schema, `additionalProperties: false` is set, but there's no `required:` block listing which properties are mandatory. This means none of the properties (reg, interrupts, clocks, etc.) are technically required by the schema. This has a Reviewed-by from Krzysztof Kozlowski, so perhaps this was intentionally left this way, but normally you'd want a `required:` section. --- Generated by Claude Code Patch Reviewer